Add text as html to orig elements chunks #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ml_to_orig_elements_chunks
unstructured/chunking/base.py
Outdated
| @@ -774,6 +774,8 @@ def iter_kwarg_pairs() -> Iterator[tuple[str, Any]]: | |||
| # -- Python 3.7+ maintains dict insertion order -- | |||
| ordered_unique_keys = {key: None for val_list in values for key in val_list} | |||
| yield field_name, list(ordered_unique_keys.keys()) | |||
| elif strategy is CS.STRING_CONCATENATE: | |||
| yield field_name, "".join(values) | |||
There was a problem hiding this comment.
Wouldn't be better " ".join(val.strip for val in values)?
| <Document> | ||
| <Page> | ||
| <Section> | ||
| <p>First </p> |
There was a problem hiding this comment.
Are the spaces here (before </p>) intended?
There was a problem hiding this comment.
They are, a bit :P
I did that intuitively; when you look at some metadata, it json it looks this way
https://github.com/Unstructured-IO/unstructured/blob/main/test_unstructured/documents/unstructured_json_output/example.json#L45
There was a problem hiding this comment.
This is the same for all 1-line htmls
There was a problem hiding this comment.
but it isn't case for HTML, so mabe I clean that from docstirng
plutasnyy
deleted the
ML-468/add_text_as_html_to_orig_elements_chunks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplest solution doesn't drop HTML from metadata when merging Elements from HTML input. We still need to address how to handle nested elements, and if we want to have
LayoutElementsin the metadata of Composite Elements, a unit test showing the current behavior.Note: metadata still contains
orig_elementswhich has all the metadata.